video: use a better vbv-bufsize & correct software bitrate calculation #33
Conversation
* Increase vbv-bufsize to 1/10 of requested bitrate. The previous value was too low, which was resulting in poor encoding quality and failure to stabilize at the requested bitrate. Setting to 1/10 of bitrate is a good compromise, as it avoids quality loss but also prevents bandwidth spikes far above the bitrate/vbv-maxrate. * With vbv-bufsize set to a more appropriate value, testing shows that the average bitrate vs client-requested bandwidth overshoots by ~20%. Adjust for this scenario in the software encoding case only.
|
Thanks for the heads up. I've no issue with this PR as-is; just keep in mind that I already submitted this change via my own PR to upstream, just in case that causes you issues when merging/rebasing (if/when it gets accepted). |
Sounds good. Thanks again! Also this repo is an import of the original project, not a fork. So as far as I know any changes here would need to be copied into a fork of the main repo and then submitted. I decided to use an import instead of a fork because forks cannot be searched and it makes it more difficult to submit PRs. Not sure what's going on with Loki, but hopefully nothing serious. The goal here is to make things more manageable and somewhat automated. |
|
Tbh I felt uncomfortable with submitting this PR as it's not my own code. Thanks @psyke83 for your openness. |
TheElixZammuto
left a comment
TheElixZammuto
left a comment
There was a problem hiding this comment.
Haven't tested this, but LGTM since the explication seems good enough and the modification is very simple
- Update based on #33 - Fix year for 2021 releases
|
Just for reference: this is the same as loki-47-6F-64/sunshine#288 |
4 participants
Description
Change cherry-picked from @psyke83 repository. It has a real impact on stream quality on my various tests.
was too low, which was resulting in poor encoding quality and failure to
stabilize at the requested bitrate. Setting to 1/10 of bitrate is a
good compromise, as it avoids quality loss but also prevents bandwidth
spikes far above the bitrate/vbv-maxrate.
the average bitrate vs client-requested bandwidth overshoots by ~20%.
Adjust for this scenario in the software encoding case only.
Screenshot
N/A
Issues Fixed or Closed
N/A
Type of Change
Checklist