Skip to content

fix(packaging): apply udev rules for uhid #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 1 commit into from
Aug 19, 2024
Merged

fix(packaging): apply udev rules for uhid #3041

ReenigneArcher merged 1 commit into from
Aug 19, 2024

Conversation

@cgutman
Copy link
Collaborator

@cgutman cgutman commented Aug 18, 2024

Description

#2606 missed several places where we need to reload uhid rules, so DS5 emulation is broken after installation on most distros.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher mentioned this pull request Aug 18, 2024
Merged
16 tasks
@codecov
Copy link

codecov bot commented Aug 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.69%. Comparing base (170f4dd) to head (7b8f97d).
Report is 132 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #3041    +/-   ##
=======================================
  Coverage    9.69%   9.69%            
=======================================
  Files         101     101            
  Lines       17913   17913            
  Branches     8376    8376            
=======================================
  Hits         1736    1736            
- Misses      13306   13457   +151     
+ Partials     2871    2720   -151
Flag Coverage Δ
Linux 7.31% <ø> (ø)
Windows 5.06% <ø> (ø)
macOS-12 10.50% <ø> (ø)
macOS-13 10.42% <ø> (+0.01%) ⬆️
macOS-14 10.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

@ReenigneArcher ReenigneArcher added this to the stable release milestone Aug 19, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ReenigneArcher ReenigneArcher merged commit 17c4b26 into LizardByte:master Aug 19, 2024
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
@cgutman
fix(packaging): apply udev rules for uhid (LizardByte#3041)
4d9a09e
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
@cgutman @c2vi
fix(packaging): apply udev rules for uhid (LizardByte#3041)
c6377a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2025.118.151840

Development

Successfully merging this pull request may close these issues.

2 participants

@cgutman @ReenigneArcher