Skip to content

Conversation

@sitiom
Copy link
Contributor

@sitiom sitiom commented Jun 17, 2022

Description

This change adds batch files to programmatically add and remove sunshine firewall rules. In my use case, if I run sunshinevc without opening Sunshine for the first time, Sunshine will silently fail and would not be discoverable within the network, as normally, you would have to deal with this popup first which sunshinevc wouldn't show:
image

Screenshot

It works as intended (admin required, of course):
image
image

Issues Fixed or Closed

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring/documentation-blocks for new or existing methods/components

@github-actions github-actions bot changed the base branch from master to nightly June 17, 2022 03:07
@github-actions
Copy link

Your PR was set to master, PRs should be sent to nightly
The base branch of this PR has been automatically changed to nightly, please check that there are no merge conflicts

@ReenigneArcher
Copy link
Member

Todo:

@sitiom
Copy link
Contributor Author

sitiom commented Aug 8, 2022

Oops, accidentally deleted the fork.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

os:Windows OS is Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows Installer should automatically add and remove firewall rules

2 participants