Skip to content

Add cpack #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 50 commits into from
Jun 15, 2022
Merged

Add cpack #144

ReenigneArcher merged 50 commits into from
Jun 15, 2022

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Apr 30, 2022 •
edited
Loading

Description

  • Replaces WIP: Moving to cpack in order to unify installers across all platforms #139
  • Use cpack to generate:
    • Linux
      • deb (tested and working on Ubuntu 20.04 VM with X11)
      • rpm (tested and working on Fedora 36 VM with Xorg)
    • MacOS
      • dmg (needs tested)
      • standalone zip (needs tested)
    • Windows
      • installer (tested and working on Windows 11)
      • standalone zip (tested and working on Windows 11)
  • Adjust packaging of Linux AppImage (tested and working on Ubuntu 20.04 VM with X11)
  • Reorganize assets

Issues Fixed or Closed

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the documentation blocks for new or existing components

ABeltramo and others added 13 commits April 30, 2022 10:24
@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Apr 30, 2022 •
edited
Loading

Todo:

  • update documenation
  • add MacOS dmg package
  • test Linux/Debian deb on various distros
  • test Linux/CentOS rpm on various distros
  • test Linux AppImage on various distros
  • test MacOS dmg package
  • test MacOS Portfile
  • test MacOS standalone package
  • test/review windows standalone archive

@ReenigneArcher

This comment was marked as resolved.

Sign in to view
@ReenigneArcher ReenigneArcher force-pushed the add-cpack branch 2 times, most recently from 31b7fbf to 2c7dfe0 Compare May 1, 2022 00:27
@abusse

This comment was marked as resolved.

Sign in to view
@abusse

This comment was marked as resolved.

Sign in to view
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
@ReenigneArcher ReenigneArcher added the help wanted Extra attention is needed label May 3, 2022
@ReenigneArcher ReenigneArcher force-pushed the add-cpack branch 5 times, most recently from 6e18ebd to 5f6e56a Compare May 3, 2022 22:21
@ReenigneArcher ReenigneArcher force-pushed the add-cpack branch 4 times, most recently from 76833c1 to cc7fc62 Compare June 13, 2022 01:57
@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Jun 13, 2022 •
edited
Loading

@abusse hoping you can help on this...

The Portfile is configured with CMakeLists now. I was able to use it on a vm and successfully install sunshine. Within the vm I was able to use sudo port pkg sunshine and sudo port dmg sunshine. Thought I would try to accomplish the same in the github runner, but getting some pretty unhelpful errors.

I tried on macos-11 and macos12, same result.

https://github.com/SunshineStream/Sunshine/runs/6853691942?check_suite_focus=true#step:7:5166

Edit: my best guess was that homebrew packages were somehow interfering with macports, but I separated the macports build into a separate job and still have the same issue.

Edit: I think the issue might be something to do with the recent update to openssl3: https://www.openssl.org/news/changelog.html#openssl-31

runner definition

https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md#utilities

similar code that can help fix the link to openssl

actions/runner-images#2089

@ReenigneArcher ReenigneArcher force-pushed the add-cpack branch 2 times, most recently from bfc4e95 to 9de187e Compare June 13, 2022 19:37
ReenigneArcher
ReenigneArcher commented Jun 13, 2022
View reviewed changes
@ReenigneArcher ReenigneArcher force-pushed the add-cpack branch 5 times, most recently from 5d80f7c to 56e5a80 Compare June 14, 2022 02:25
ReenigneArcher
ReenigneArcher commented Jun 14, 2022
View reviewed changes
@ReenigneArcher ReenigneArcher force-pushed the add-cpack branch 2 times, most recently from f83291e to aa532c0 Compare June 15, 2022 16:43
@ReenigneArcher ReenigneArcher merged commit f5d7cf7 into nightly Jun 15, 2022
@ReenigneArcher ReenigneArcher deleted the add-cpack branch June 15, 2022 21:12
This was referenced Jun 15, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ABeltramo ABeltramo ABeltramo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

help wanted Extra attention is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ReenigneArcher @abusse @ABeltramo @cazzoo