Skip to content

Conversation

@ns6089
Copy link
Contributor

@ns6089 ns6089 commented Apr 4, 2023

Description

Compilation fails on Clang 14.0.0 x86_64-apple-darwin21.6.0 from Xcode 14.2 with the following message:

[build] /Users/user/Documents/Sunshine/src/thread_safe.h:450:52: error: implicit instantiation of undefined template 'std::array<unsigned char, 128>'
[build]     std::array<std::uint8_t, sizeof(element_type)> _object_buf;

Including the missing header fixes the problem.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@cgutman cgutman force-pushed the fix_array_include branch from 286499a to 8590049 Compare April 6, 2023 01:17
@cgutman cgutman merged commit 290c9b3 into LizardByte:nightly Apr 6, 2023
@ns6089 ns6089 deleted the fix_array_include branch April 16, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants