Skip to content

feat: add min_fps_target setting #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 1 commit into from
Jun 19, 2024
Merged

feat: add min_fps_target setting #1043

ReenigneArcher merged 1 commit into from
Jun 19, 2024

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Mar 15, 2023 •
edited
Loading

Description

Add minimum fps target setting to help in situations where 10 fps is too low.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the config-add-fps-floor-setting branch 2 times, most recently from efc275f to ad20ac1 Compare March 15, 2023 22:38
Nonary

This comment was marked as resolved.

Sign in to view

@ReenigneArcher ReenigneArcher force-pushed the config-add-fps-floor-setting branch 2 times, most recently from 0867994 to 900655e Compare March 16, 2023 00:39
psyke83
psyke83 reviewed Mar 16, 2023
View reviewed changes
@ReenigneArcher ReenigneArcher force-pushed the config-add-fps-floor-setting branch from 900655e to 6721fe4 Compare March 16, 2023 01:44
@psyke83

This comment was marked as resolved.

Sign in to view
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
@ReenigneArcher ReenigneArcher marked this pull request as draft March 16, 2023 02:24
@Nonary

This comment was marked as outdated.

Sign in to view
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
@ReenigneArcher ReenigneArcher force-pushed the config-add-fps-floor-setting branch from 6721fe4 to 0870c09 Compare March 16, 2023 15:27
@ReenigneArcher ReenigneArcher changed the title config: add min_fps setting config: add min_fps_target setting Mar 16, 2023
@ReenigneArcher ReenigneArcher force-pushed the config-add-fps-floor-setting branch from 0870c09 to af76a8a Compare March 16, 2023 15:31
@ReenigneArcher ReenigneArcher marked this pull request as ready for review March 16, 2023 15:37
@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Mar 16, 2023

This is working now. I was missing the part where it reads the config option from the saved config file so it was always using the default value.

I also renamed the setting to min_fps_target as setting this to a high value wouldn't guarantee a high FPS, which would have probably been misleading.

For me, if I set the value to 1 FPS, my stream is about 7-8 FPS (according to Moonlight) with static content. If I set to 240 FPS, I get about 65-68 FPS. I only tested on my laptop with integrated AMD graphics, with all other options as default.

psyke83
psyke83 reviewed Mar 23, 2023
View reviewed changes
ReenigneArcher
ReenigneArcher commented Mar 23, 2023
View reviewed changes
@ReenigneArcher ReenigneArcher marked this pull request as draft March 28, 2023 01:06
@ReenigneArcher

This comment was marked as resolved.

Sign in to view
@ReenigneArcher ReenigneArcher force-pushed the config-add-fps-floor-setting branch 5 times, most recently from 854a8a2 to acb1750 Compare March 28, 2023 14:53
@ReenigneArcher ReenigneArcher force-pushed the config-add-fps-floor-setting branch from acb1750 to 84ae8a9 Compare April 5, 2023 14:44
@LizardByte-bot

This comment was marked as off-topic.

Sign in to view
@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented May 5, 2023

@cgutman do you think this PR should be resumed? I know there's been a lot of activity to try to improve streaming performance, and I don't know if this is still relevant.

@ReenigneArcher ReenigneArcher deleted the config-add-fps-floor-setting branch May 7, 2023 19:44
@ReenigneArcher ReenigneArcher restored the config-add-fps-floor-setting branch March 21, 2024 13:21
@Jocelyn-JE
Copy link

Jocelyn-JE commented Mar 21, 2024

This change seems to improve slightly the number of microstutters when switching from a static image to an active one and back. Needs further testing / changes.

@ReenigneArcher ReenigneArcher mentioned this pull request Apr 19, 2024
Closed
3 tasks
@ReenigneArcher ReenigneArcher force-pushed the config-add-fps-floor-setting branch from 84ae8a9 to 369dcff Compare June 18, 2024 21:43
@codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 8.96%. Comparing base (d6dd1ab) to head (f651fc9).
Report is 144 commits behind head on master.

Files with missing lines Patch % Lines
src/video.cpp 0.00% 0 Missing and 3 partials ⚠️
src/config.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #1043      +/-   ##
=========================================
- Coverage    8.97%   8.96%   -0.01%     
=========================================
  Files          94      94              
  Lines       17389   17392       +3     
  Branches     8267    8270       +3     
=========================================
  Hits         1560    1560              
  Misses      12967   12967              
- Partials     2862    2865       +3
Flag Coverage Δ
Linux 6.79% <0.00%> (-0.01%) ⬇️
Windows 4.16% <0.00%> (-0.01%) ⬇️
macOS-12 10.04% <0.00%> (-0.01%) ⬇️
macOS-13 9.95% <0.00%> (+<0.01%) ⬆️
macOS-14 10.24% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/config.h 0.00% <ø> (ø)
src/config.cpp 4.77% <0.00%> (-0.01%) ⬇️
src/video.cpp 25.23% <0.00%> (-0.05%) ⬇️

@ReenigneArcher ReenigneArcher force-pushed the config-add-fps-floor-setting branch 2 times, most recently from d3a4f39 to 18b0b3c Compare June 18, 2024 23:09
@ReenigneArcher ReenigneArcher force-pushed the config-add-fps-floor-setting branch from 18b0b3c to f651fc9 Compare June 18, 2024 23:15
@ReenigneArcher ReenigneArcher marked this pull request as ready for review June 18, 2024 23:19
@ReenigneArcher ReenigneArcher changed the title config: add min_fps_target setting feat: add min_fps_target setting Jun 18, 2024
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) June 19, 2024 00:00
@ReenigneArcher ReenigneArcher merged commit 722e560 into master Jun 19, 2024
@ReenigneArcher ReenigneArcher deleted the config-add-fps-floor-setting branch June 19, 2024 00:09
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
@ReenigneArcher
feat: add min_fps_target setting (LizardByte#1043)
dd25e06
@ReenigneArcher ReenigneArcher mentioned this pull request Jan 11, 2025
Closed
2 tasks
This was referenced Jan 18, 2025
Merged
Closed
Merged
@hello-world-321 hello-world-321 mentioned this pull request Jan 20, 2025
Closed
@ReenigneArcher ReenigneArcher mentioned this pull request Jan 22, 2025
Merged
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
@ReenigneArcher @c2vi
feat: add min_fps_target setting (LizardByte#1043)
c3484ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@psyke83 psyke83 psyke83 left review comments

@Nonary Nonary Nonary requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Chromebook Screen Flickering Issues Screen flicker on Chromebook

6 participants

@ReenigneArcher @psyke83 @Nonary @LizardByte-bot @Jocelyn-JE