Error passing argument 4 of notify_notification_add_action #3840
Description
Is there an existing issue for this?
- I have searched the existing issues
Is your issue described in the documentation?
- I have read the documentation
Is your issue present in the latest beta/pre-release?
This issue is present in the latest pre-release
Describe the Bug
/tmp/sunshine-git/src/Sunshine/third-party/tray/src/tray_linux.c: In function ‘tray_update_internal’:
/tmp/sunshine-git/src/Sunshine/third-party/tray/src/tray_linux.c:103:87: error: passing argument 4 of ‘notify_notification_add_action’ from incompatible pointer type [-Wincompatible-pointer-types]
103 | notify_notification_add_action(currentNotification, "default", "Default", tray->notification_cb, NULL, NULL);
| ~~~~^~~~~~~~~~~~~~~~~
| |
| void (*)(void)
In file included from /usr/include/libnotify/notify.h:27,
from /tmp/sunshine-git/src/Sunshine/third-party/tray/src/tray_linux.c:19:
/usr/include/libnotify/notification.h:202:85: note: expected ‘NotifyActionCallback’ {aka ‘void (*)(NotifyNotification *, char *, void *)’} but argument is of type ‘void (*)(void)’
202 | NotifyActionCallback callback,
| ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/usr/include/libnotify/notification.h:120:19: note: ‘NotifyActionCallback’ declared here
120 | typedef void (*NotifyActionCallback) (NotifyNotification *notification,
| ^~~~~~~~~~~~~~~~~~~~
Expected Behavior
Expected sunshine master to compile.
Additional Context
I build master regularly, this is a recently intruduced issue. I suspect the interface of libnotify changed.
Host Operating System
Linux
Operating System Version
Arch Linux, kernel 6.14.4
Architecture
amd64/x86_64
Sunshine commit or version
Package
other (self built)
GPU Type
NVIDIA
GPU Model
4090
GPU Driver/Mesa Version
570.144
Capture Method
KMS (Linux)
Config
resolutions = [
1280x720,
1920x1080,
1920x1200,
2880x1920,
3840x2160,
7680x4320
]
fps = [30,60]
origin_web_ui_allowed = pc
min_log_level = infoApps
n/aRelevant log output
n/a