Fix image leak if a parallel encoder quit without encoding all pending images

cgutman · cgutman · commit adbfd098ba3f · 2023-01-02T11:49:36.000-06:00
diff --git a/src/video.cpp b/src/video.cpp
@@ -1408,6 +1408,12 @@ void capture_async(
       std::move(hwdevice),
       ref->reinit_event, *ref->encoder_p,
       channel_data);
+
+    // Free images that weren't consumed by the encoder before it quit.
+    // This is critical to allow the display_t to be freed correctly.
+    while(images->peek()) {
+      images->pop();
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1408,6 +1408,12 @@ void capture_async(`
`1408`	`1408`	`std::move(hwdevice),`
`1409`	`1409`	`ref->reinit_event, *ref->encoder_p,`
`1410`	`1410`	`channel_data);`
	`1411`	`+`
	`1412`	`+ // Free images that weren't consumed by the encoder before it quit.`
	`1413`	`+ // This is critical to allow the display_t to be freed correctly.`
	`1414`	`+ while(images->peek()) {`
	`1415`	`+ images->pop();`
	`1416`	`+ }`
`1411`	`1417`	`}`
`1412`	`1418`	`}`
`1413`	`1419`