Skip to content
This repository was archived by the owner on Oct 13, 2024. It is now read-only.

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Jan 14, 2023

Description

Update docker workflow, based on changes from LizardByte/Sunshine#714. It is intended that this workflow file works universally for all our docker projects.

Todo:

  • Test if workflow functions without an artifacts build stage in dockerfile. (Does not work without)
  • Move workflow to .github repo.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher merged commit b30f7d7 into nightly Jan 16, 2023
@ReenigneArcher ReenigneArcher deleted the update-docker-workflow branch January 16, 2023 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants