Repository navigation
Commit 4e7b69e
fix: keep -0.0 rows in TopK dynamic filter when the threshold is a float zero
The TopK heap orders -0.0 before 0.0, but comparisons treat them as equal
since apache#22835, so a filter like `x < 0.0 OR (x = 0.0 AND y < 1)` dropped
-0.0 rows that belong in the result. For a ±0.0 threshold use a non-strict
bound and stop filtering on later sort keys.
Closes apache#26618
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent cd571e5 commit 4e7b69e
2 files changed
Lines changed: 74 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
362 | 362 | | |
363 | 363 | | |
364 | 364 | | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
365 | 376 | | |
366 | 377 | | |
367 | 378 | | |
| |||
643 | 654 | | |
644 | 655 | | |
645 | 656 | | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
646 | 664 | | |
647 | | - | |
| 665 | + | |
648 | 666 | | |
649 | | - | |
650 | | - | |
| 667 | + | |
| 668 | + | |
651 | 669 | | |
652 | | - | |
| 670 | + | |
| 671 | + | |
653 | 672 | | |
654 | 673 | | |
655 | 674 | | |
| |||
708 | 727 | | |
709 | 728 | | |
710 | 729 | | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
711 | 734 | | |
712 | 735 | | |
713 | 736 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
824 | 824 | | |
825 | 825 | | |
826 | 826 | | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
| 835 | + | |
| 836 | + | |
| 837 | + | |
| 838 | + | |
| 839 | + | |
| 840 | + | |
| 841 | + | |
| 842 | + | |
| 843 | + | |
| 844 | + | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
0 commit comments