Merge from microsoft/vscode master#4
Merged
Linskeyd merged 1223 commits intoLinskeyd:masterfrom Oct 1, 2019
Merged
Conversation
Improve LinkDetector
* working on the left side * flow direction working * flow direction * use menubar visibility to set setting * hide titlebar on the web * fix hover feedback
This way debug sessions sharing a single repl will all be notified about new repl elements and UI will be updated.
Discovered as part of #81574
Remove focus outline on settings editor. It's not tabbable so it doesn't serve any purpose and is annoying to see every time I click on the editor background. Just need to keep .editor-instance from getting focus on click. Fix #81675
- Fix keyboard shortcut to show context menu - Fix showing gear icon when settings row is focused
Fixes #80617 Some extensions may provide us with bad data types (if they are js or don't have strict null enabled for example). Try to be more careful about handling such cases by falling back to an empty array instead of undefined
It needs more polishing and should probably only be enabled for files that may have custom editors enabled
These features are not working in many cases and the api around them will likely change significantly
Linskeyd
pushed a commit
that referenced
this pull request
Oct 1, 2019
… search (microsoft#80495) * Added buildRegexParseError for better parsing error message * Fixed message * Review #1 changes * Changed error message as per review #2 * Review #3 changes * Review #4 changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.