Fix memory issues when computing retrieval metrics with high-valued indices#3291
Merged
justusschock merged 3 commits intoMar 4, 2026
Merged
Conversation
adaliaramon
requested review from
Borda,
SkafteNicki and
justusschock
as code owners
October 16, 2025 10:53
justusschock
approved these changes
Oct 16, 2025
justusschock
left a comment
justusschock
left a comment
Member
There was a problem hiding this comment.
Very Nice @adaliaramon ! Do you have comparison numbers in memory usage?
Contributor
Author
|
Not really but just from the example in the issue it comes down from 67 GB to basically nothing |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3291 +/- ##
=======================================
- Coverage 37% 37% -1%
=======================================
Files 364 349 -15
Lines 20098 19901 -197
=======================================
- Hits 7521 7327 -194
+ Misses 12577 12574 -3 🚀 New features to boost your workflow:
|
rittik9
force-pushed
the
fix-retrieval-memory-issues
branch
from
January 29, 2026 15:06
c6b86ce to
4c3094d
Compare
justusschock
approved these changes
Mar 3, 2026
bhimrazy
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3290. No update to the docs or new test are required, as far as I can tell. Tests are passing.
Before submitting
PR review
Memory usage is now independent of the values of the indices.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--3291.org.readthedocs.build/en/3291/