fix: return NaN when no threshold meets min recall/precision in binary metrics#3226
Merged
Borda merged 6 commits intoAug 15, 2025
Merged
Conversation
iamkulbhushansingh
requested review from
Borda,
SkafteNicki and
justusschock
as code owners
August 13, 2025 18:20
Borda
approved these changes
Aug 13, 2025
Collaborator
|
pls add chlog entry :) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3226 +/- ##
========================================
- Coverage 69% 40% -28%
========================================
Files 364 349 -15
Lines 20073 19878 -195
========================================
- Hits 13788 7991 -5797
- Misses 6285 11887 +5602 🚀 New features to boost your workflow:
|
Borda
pushed a commit
that referenced
this pull request
Sep 3, 2025
…y metrics (#3226) * Replace hardcoded 1e6 threshold with NaN in precision/recall fixed metrics * fixed doc test for functional classification too * precision fix from scientific notation to normal for CI testing --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 58249cb)
Borda
pushed a commit
that referenced
this pull request
Sep 3, 2025
…y metrics (#3226) * Replace hardcoded 1e6 threshold with NaN in precision/recall fixed metrics * fixed doc test for functional classification too * precision fix from scientific notation to normal for CI testing --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 58249cb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
1e6threshold withNaNin:BinaryPrecisionAtFixedRecallBinaryRecallAtFixedPrecisionNaNis returned when no threshold satisfies the recall/precision condition.Partially Fixes #2873
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If this change was not discussed in a GitHub issue, it may take longer to review.
Did you have fun?
Yes, As always.