fix: ignore zero and negative predictions in retrieval metrics#3160
Merged
Conversation
rittik9
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #3160 +/- ##
========================================
- Coverage 70% 34% -36%
========================================
Files 364 349 -15
Lines 20060 19870 -190
========================================
- Hits 14084 6703 -7381
- Misses 5976 13167 +7191 🚀 New features to boost your workflow:
|
rittik9
changed the title
Collaborator
Author
|
Hi @Borda, this one is ready for review. This solves the problem mentioned in original pr. As that pr needed a lot of changes so I opened a new one. |
Borda
approved these changes
Jul 2, 2025
Borda
added a commit
that referenced
this pull request
Jul 3, 2025
* feat: ignore zero and negative preds * update average_precision to ignore zero and negative predictions * update recall to ignore zero and negative predictions * update precision to ignore zero and negative predictions * add tests --------- Co-authored-by: AymenKallala <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 393f62b)
Borda
added a commit
that referenced
this pull request
Jul 5, 2025
* feat: ignore zero and negative preds * update average_precision to ignore zero and negative predictions * update recall to ignore zero and negative predictions * update precision to ignore zero and negative predictions * add tests --------- Co-authored-by: AymenKallala <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 393f62b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3104
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--3160.org.readthedocs.build/en/3160/