Corrected formula for negative predictive value#3124
Merged
Conversation
C00kieFact0ry
requested review from
Borda,
SkafteNicki and
justusschock
as code owners
June 8, 2025 20:43
rittik9
approved these changes
Jun 9, 2025
Borda
approved these changes
Jun 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #3124 +/- ##
========================================
- Coverage 70% 41% -30%
========================================
Files 359 345 -14
Lines 19891 19701 -190
========================================
- Hits 13930 7981 -5949
- Misses 5961 11720 +5759 🚀 New features to boost your workflow:
|
Borda
added a commit
that referenced
this pull request
Jun 12, 2025
Co-authored-by: Arman Naseri <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 2b27bd9)
Borda
added a commit
that referenced
this pull request
Jun 13, 2025
Co-authored-by: Arman Naseri <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 2b27bd9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The docs for NPV define it as TN / (TN + FP), which is the specificity. The NPV should be TN / (TN + FN)
Note: NPV is only misstated in the docs, the implementation itself is correct:
torchmetrics/src/torchmetrics/functional/classification/negative_predictive_value.py
Line 50 in 56aadd6
Solution
Corrected the docs formula and text to reflect the correct formula for NPV.
📚 Documentation preview 📚: https://torchmetrics--3124.org.readthedocs.build/en/3124/