Skip to content

Fix: Ensure WrapperMetric Resets wrapped_metric State#3123

Merged
Borda merged 6 commits into
Lightning-AI:masterfrom
rittik9:patch-7
Jun 10, 2025
Merged

Fix: Ensure WrapperMetric Resets wrapped_metric State#3123
Borda merged 6 commits into
Lightning-AI:masterfrom
rittik9:patch-7

Conversation

@rittik9

@rittik9 rittik9 commented Jun 7, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes #3122

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--3123.org.readthedocs.build/en/3123/

@rittik9 rittik9 changed the title Fix: Ensure WrapperMetric Resets Wrapped Metric State Fix: Ensure WrapperMetric Resets wrapped_metric State Jun 7, 2025
@codecov

codecov Bot commented Jun 7, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 36%. Comparing base (56aadd6) to head (e785e8c).
⚠️ Report is 106 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (56aadd6) and HEAD (e785e8c). Click for more details.

HEAD has 102 uploads less than BASE
Flag BASE (56aadd6) HEAD (e785e8c)
cpu 40 16
python3.12 24 4
torch2.7.1+cpu 13 3
Windows 7 2
torch2.0.1+cpu 8 3
Linux 26 11
torch2.6.0+cpu 7 2
python3.9 6 1
torch2.7.1 6 1
macOS 7 3
gpu 2 0
unittest 2 0
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #3123     +/-   ##
========================================
- Coverage      70%     36%    -34%     
========================================
  Files         359     345     -14     
  Lines       19892   19705    -187     
========================================
- Hits        13931    7100   -6831     
- Misses       5961   12605   +6644     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Borda
Borda merged commit a02d241 into Lightning-AI:master Jun 10, 2025
@mergify mergify Bot added the ready label Jun 10, 2025
Borda pushed a commit that referenced this pull request Jun 12, 2025
* Update transformations.py
* Update test_transformations.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

(cherry picked from commit a02d241)
Borda pushed a commit that referenced this pull request Jun 13, 2025
* Update transformations.py
* Update test_transformations.py

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

(cherry picked from commit a02d241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WrapperMetric does not reset the state of the wrapped metric

2 participants