Skip to content

Fix ignore_index in MultilabelExactMatch #3085

Merged
SkafteNicki merged 9 commits into
Lightning-AI:masterfrom
rittik9:exact_match
May 9, 2025
Merged

Fix ignore_index in MultilabelExactMatch #3085
SkafteNicki merged 9 commits into
Lightning-AI:masterfrom
rittik9:exact_match

Conversation

@rittik9

@rittik9 rittik9 commented May 7, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes #3083

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--3085.org.readthedocs.build/en/3085/

@rittik9 rittik9 changed the title Fix ignore_index in MultilabelExactMatch Fix ignore_index in MultilabelExactMatch [WIP] May 7, 2025
@codecov

codecov Bot commented May 7, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 40%. Comparing base (3fffd01) to head (ee0888b).
⚠️ Report is 95 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3fffd01) and HEAD (ee0888b). Click for more details.

HEAD has 132 uploads less than BASE
Flag BASE (3fffd01) HEAD (ee0888b)
torch2.7.0 3 1
macOS 9 3
cpu 48 16
python3.12 12 4
torch2.0.1+cpu 9 3
python3.10 33 11
Windows 6 2
torch2.7.0+cpu 9 3
torch2.0.1 6 2
gpu 2 0
unittest 2 0
Linux 33 11
torch2.6.0+cpu 6 2
torch2.2.2+cpu 3 1
torch2.5.1+cpu 3 1
torch2.3.1+cpu 3 1
torch2.4.1+cpu 3 1
torch2.1.2+cpu 3 1
python3.9 3 1
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #3085     +/-   ##
========================================
- Coverage      70%     40%    -30%     
========================================
  Files         357     343     -14     
  Lines       19778   19593    -185     
========================================
- Hits        13863    7929   -5934     
- Misses       5915   11664   +5749     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rittik9 rittik9 changed the title Fix ignore_index in MultilabelExactMatch [WIP] Fix ignore_index in MultilabelExactMatch May 7, 2025
Comment thread src/torchmetrics/classification/exact_match.py Outdated
@mergify mergify Bot added the ready label May 7, 2025
@SkafteNicki
SkafteNicki merged commit cbae979 into Lightning-AI:master May 9, 2025
Borda pushed a commit that referenced this pull request May 27, 2025
* fix ignore_index multilabel_exact_match

* update test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix unittests

* fix unittests

* fix unittests

* fix unittests

* update chlog

* pass as kwargs

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit cbae979)
Borda pushed a commit that referenced this pull request May 28, 2025
* fix ignore_index multilabel_exact_match

* update test

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix unittests

* fix unittests

* fix unittests

* fix unittests

* update chlog

* pass as kwargs

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit cbae979)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MultilabelExactMatch agnostic to 'ignore_index'

3 participants