Skip to content

Enhance: BERTScore to evaluate hypotheses against multiple references#3069

Merged
Borda merged 40 commits into
Lightning-AI:masterfrom
rittik9:rittik/bert_multiref
May 9, 2025
Merged

Enhance: BERTScore to evaluate hypotheses against multiple references#3069
Borda merged 40 commits into
Lightning-AI:masterfrom
rittik9:rittik/bert_multiref

Conversation

@rittik9

@rittik9 rittik9 commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes #647

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--3069.org.readthedocs.build/en/3069/

@rittik9
rittik9 force-pushed the rittik/bert_multiref branch 3 times, most recently from b6c1daf to 2de8653 Compare April 29, 2025 10:04
@rittik9 rittik9 changed the title Enhance: BERTScore to evaluate hypotheses against multiple references [WIP] Enhance: BERTScore to evaluate hypotheses against multiple references May 1, 2025
@rittik9
rittik9 marked this pull request as ready for review May 1, 2025 20:53
@rittik9

rittik9 commented May 1, 2025

Copy link
Copy Markdown
Collaborator Author

Tests are yet to be added.

@codecov

codecov Bot commented May 1, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 35.08772% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 38%. Comparing base (cbae979) to head (efd3545).
⚠️ Report is 96 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (cbae979) and HEAD (efd3545). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (cbae979) HEAD (efd3545)
gpu 2 0
unittest 2 0
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #3069     +/-   ##
========================================
- Coverage      70%     38%    -32%     
========================================
  Files         357     343     -14     
  Lines       19781   19643    -138     
========================================
- Hits        13866    7547   -6319     
- Misses       5915   12096   +6181     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/torchmetrics/functional/text/bert.py Outdated
@rittik9
rittik9 requested a review from Borda May 4, 2025 20:15
@rittik9

rittik9 commented May 4, 2025

Copy link
Copy Markdown
Collaborator Author

@Borda @SkafteNicki this one is ready for review

@SkafteNicki SkafteNicki added the enhancement New feature or request label May 5, 2025
@SkafteNicki SkafteNicki added this to the v1.8.0 milestone May 5, 2025
Comment thread src/torchmetrics/functional/text/bert.py Outdated
Comment thread src/torchmetrics/functional/text/bert.py Outdated
Comment thread src/torchmetrics/functional/text/bert.py Outdated
@rittik9
rittik9 force-pushed the rittik/bert_multiref branch from 0090a72 to d557b92 Compare May 5, 2025 11:12
@rittik9
rittik9 marked this pull request as draft May 5, 2025 12:20
@rittik9
rittik9 marked this pull request as ready for review May 5, 2025 12:36
@rittik9
rittik9 requested a review from SkafteNicki May 5, 2025 12:37
@mergify mergify Bot added the ready label May 5, 2025
@rittik9
rittik9 force-pushed the rittik/bert_multiref branch from f71efdb to 1d27fc7 Compare May 6, 2025 11:55
@rittik9
rittik9 force-pushed the rittik/bert_multiref branch from 1d27fc7 to d3a40c5 Compare May 8, 2025 19:16
@Borda
Borda merged commit ddba8c4 into Lightning-AI:master May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable BERTScore evaluates hypotheses against multiple references.

3 participants