Fix: MIFID incorrectly converts inputs to byte dtype with custom encoders#3064
Merged
Conversation
rittik9
requested review from
Borda,
SkafteNicki and
justusschock
as code owners
April 15, 2025 14:40
rittik9
changed the title
byte dtype with custom encodersbyte dtype with custom encoders [WIP]
rittik9
marked this pull request as draft
April 15, 2025 14:49
rittik9
marked this pull request as ready for review
April 15, 2025 15:37
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3064 +/- ##
========================================
- Coverage 70% 37% -33%
========================================
Files 357 343 -14
Lines 19757 19571 -186
========================================
- Hits 13852 7310 -6542
- Misses 5905 12261 +6356 🚀 New features to boost your workflow:
|
rittik9
changed the title
byte dtype with custom encoders [WIP]byte dtype with custom encoders
Borda
approved these changes
Apr 16, 2025
SkafteNicki
reviewed
Apr 23, 2025
SkafteNicki
approved these changes
Apr 23, 2025
Borda
pushed a commit
that referenced
this pull request
May 27, 2025
…coders (#3064) * Fix MIFID conversion to byte dtype with custom encoders * add unittest * Update CHANGELOG.md * clean up test_mifid.py * add arg description --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> (cherry picked from commit 60e7686)
Borda
pushed a commit
that referenced
this pull request
May 28, 2025
…coders (#3064) * Fix MIFID conversion to byte dtype with custom encoders * add unittest * Update CHANGELOG.md * clean up test_mifid.py * add arg description --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Nicki Skafte Detlefsen <[email protected]> (cherry picked from commit 60e7686)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3062
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--3064.org.readthedocs.build/en/3064/