Skip to content

Enhance add 'none'option to LPIPS reduction parameter to enable per-sample scores#3053

Merged
Borda merged 14 commits into
Lightning-AI:masterfrom
rittik9:rittik/lpip
Apr 9, 2025
Merged

Enhance add 'none'option to LPIPS reduction parameter to enable per-sample scores#3053
Borda merged 14 commits into
Lightning-AI:masterfrom
rittik9:rittik/lpip

Conversation

@rittik9

@rittik9 rittik9 commented Apr 8, 2025

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes #3052

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--3053.org.readthedocs.build/en/3053/

@codecov

codecov Bot commented Apr 8, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 37%. Comparing base (9cddf60) to head (230e001).
Report is 79 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9cddf60) and HEAD (230e001). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (9cddf60) HEAD (230e001)
gpu 3 0
unittest 3 0
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #3053     +/-   ##
========================================
- Coverage      70%     37%    -33%     
========================================
  Files         357     343     -14     
  Lines       19744   19559    -185     
========================================
- Hits        13847    7310   -6537     
- Misses       5897   12249   +6352     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rittik9 rittik9 changed the title Enhance add 'none'option to LPIPS reduction parameter to enable per-sample scores [WIP] Enhance add 'none'option to LPIPS reduction parameter to enable per-sample scores Apr 8, 2025
@SkafteNicki SkafteNicki added the enhancement New feature or request label Apr 9, 2025
@SkafteNicki SkafteNicki added this to the v1.8.0 milestone Apr 9, 2025
@mergify mergify Bot added the ready label Apr 9, 2025
Comment thread src/torchmetrics/image/lpip.py Outdated
Comment thread src/torchmetrics/functional/image/lpips.py Outdated
@Borda

Borda commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator

@rittik9 pls check the docs issue:
/home/runner/work/torchmetrics/torchmetrics/src/torchmetrics/image/lpip.py:docstring of torchmetrics.image.lpip.LearnedPerceptualImagePatchSimilarity:27: WARNING: Definition list ends without a blank line; unexpected unindent.

@Borda
Borda merged commit 83f5bfc into Lightning-AI:master Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to skip reduction for LPIPS

3 participants