Remove classification Dice#3017
Merged
Merged
Conversation
github-actions
Bot
added
documentation
SkafteNicki
marked this pull request as ready for review
March 18, 2025 09:15
SkafteNicki
requested review from
Borda,
justusschock,
lantiga and
stancld
as code owners
March 18, 2025 09:15
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3017 +/- ##
=======================================
+ Coverage 69% 70% +1%
=======================================
Files 354 352 -2
Lines 19826 19483 -343
=======================================
- Hits 13749 13690 -59
+ Misses 6077 5793 -284 🚀 New features to boost your workflow:
|
Borda
approved these changes
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of issue raised in #3014
Removes Dice from classification since it has been deprecated since v1.6 and set to removal in v1.7.
The reason for the removal of so much code is that we have kept a lot of legacy code around from before the classification refactor (bask in v0.11 I think) just because this particular Dice implementation depended on it.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--3017.org.readthedocs.build/en/3017/