Skip to content

Newmetric: EER#3013

Merged
Borda merged 17 commits into
masterfrom
newmetric/eer
Mar 18, 2025
Merged

Newmetric: EER#3013
Borda merged 17 commits into
masterfrom
newmetric/eer

Conversation

@SkafteNicki

@SkafteNicki SkafteNicki commented Mar 17, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes #3002

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

📚 Documentation preview 📚: https://torchmetrics--3013.org.readthedocs.build/en/3013/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Mar 17, 2025
@SkafteNicki SkafteNicki added this to the v1.7.0 milestone Mar 17, 2025
@SkafteNicki SkafteNicki self-assigned this Mar 17, 2025
@github-actions github-actions Bot added documentation Improvements or additions to documentation topic: Classif labels Mar 17, 2025
@codecov

codecov Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 57.95455% with 37 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (b73f282) to head (d2ee2aa).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #3013   +/-   ##
======================================
- Coverage      70%     70%   -0%     
======================================
  Files         353     355    +2     
  Lines       19536   19625   +89     
======================================
+ Hits        13708   13760   +52     
- Misses       5828    5865   +37
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SkafteNicki
SkafteNicki marked this pull request as ready for review March 17, 2025 12:19
@mergify mergify Bot added the ready label Mar 17, 2025
Borda
Borda reviewed Mar 17, 2025
View reviewed changes
Comment thread docs/source/classification/eer.rst Outdated
@mergify mergify Bot removed the has conflicts label Mar 18, 2025
@Borda
Borda merged commit 03200cc into master Mar 18, 2025
@Borda
Borda deleted the newmetric/eer branch March 18, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes
@lantiga lantiga Awaiting requested review from lantiga
@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner
@stancld stancld Awaiting requested review from stancld

Assignees

@SkafteNicki SkafteNicki

Labels

documentation Improvements or additions to documentation enhancement New feature or request ready topic: Classif

Projects

None yet

Milestone

v1.7.0

Development

Successfully merging this pull request may close these issues.

Add Equal Error Rate (EER) as a metric

2 participants

@SkafteNicki @Borda