Skip to content

functional map implementation#3011

Merged
Borda merged 17 commits into
Lightning-AI:masterfrom
Isalia20:functional-map-new
Mar 18, 2025
Merged

functional map implementation#3011
Borda merged 17 commits into
Lightning-AI:masterfrom
Isalia20:functional-map-new

Conversation

@Isalia20

@Isalia20 Isalia20 commented Mar 15, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #2877

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

📚 Documentation preview 📚: https://torchmetrics--3011.org.readthedocs.build/en/3011/

@codecov

codecov Bot commented Mar 16, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 42 lines in your changes missing coverage. Please review.

Project coverage is 35%. Comparing base (147228b) to head (dd0c9fe).
Report is 71 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (147228b) and HEAD (dd0c9fe). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (147228b) HEAD (dd0c9fe)
gpu 2 0
unittest 2 0
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #3011     +/-   ##
========================================
- Coverage      70%     35%    -35%     
========================================
  Files         352     339     -13     
  Lines       19489   19350    -139     
========================================
- Hits        13696    6862   -6834     
- Misses       5793   12488   +6695     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Isalia20
Isalia20 requested a review from lantiga as a code owner March 16, 2025 09:39
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Mar 16, 2025
@Isalia20

Copy link
Copy Markdown
Contributor Author

ready for review

Comment thread src/torchmetrics/detection/helpers.py
Comment thread src/torchmetrics/detection/helpers.py
Comment thread src/torchmetrics/detection/helpers.py Outdated
Comment thread src/torchmetrics/detection/mean_ap.py Outdated
Comment thread src/torchmetrics/functional/detection/map.py
Comment thread src/torchmetrics/functional/detection/map.py
@mergify mergify Bot added the ready label Mar 17, 2025
Comment thread src/torchmetrics/functional/detection/map.py Outdated
Comment thread src/torchmetrics/functional/detection/map.py
@mergify mergify Bot removed the ready label Mar 17, 2025
@Isalia20

Copy link
Copy Markdown
Contributor Author

should be ready, one test failed but that's not related to this PR

@Borda
Borda enabled auto-merge (squash) March 18, 2025 14:45
@Borda
Borda merged commit b73f282 into Lightning-AI:master Mar 18, 2025
@mergify mergify Bot added the ready label Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready topic: Detect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Functional Interface for MeanAveragePrecision

3 participants