CLIP score improvements#2978
Merged
Merged
Conversation
SkafteNicki
marked this pull request as ready for review
March 3, 2025 12:34
SkafteNicki
requested review from
Borda,
justusschock and
stancld
as code owners
March 3, 2025 12:34
4 tasks
Collaborator
|
seems like just the docs are failing with warnings? |
Collaborator
Author
|
@Borda no there are also failing gpu tests (the test for clip score only runs on gpu, else it would take too long on cpu) |
Collaborator
GPU testing is fine :) Let's try to pass it as PIL image instead? |
justusschock
approved these changes
Mar 6, 2025
justusschock
reviewed
Mar 6, 2025
Collaborator
Collaborator
Author
|
@Borda is there a way to get more info from azure? it is hard to debug without what is going wrong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2935
Fixes #2906
Fixes #2883
Add the possibility for more multimodel models that supports longer captions than the original clip model.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2978.org.readthedocs.build/en/2978/