add ARNIQA metric#2953
Merged
Merged
Conversation
LorenzoAgnolucci
requested review from
Borda,
SkafteNicki,
justusschock,
lantiga and
stancld
as code owners
February 12, 2025 14:56
github-actions
Bot
added
documentation
Borda
reviewed
Feb 13, 2025
Borda
reviewed
Feb 13, 2025
Borda
reviewed
Feb 13, 2025
Borda
reviewed
Feb 13, 2025
Borda
reviewed
Feb 13, 2025
Borda
reviewed
Feb 13, 2025
# Conflicts: # src/torchmetrics/functional/image/arniqa.py
Contributor
Author
|
@Borda @lantiga @SkafteNicki @justusschock @stancld could you please let me know if I need to make any further changes to the PR? |
Collaborator
|
@LorenzoAgnolucci I had to tweak bit the autocasting section since it was supported on older Torch versions, so wondering how important it is if you say it needed we just restrict that this metric will be supported only on newer Torch versions... |
Contributor
Author
It's not that important, so your modifications are completely fine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2887. Add ARNIQA functional and module support.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2953.org.readthedocs.build/en/2953/