Tracking Eclipse .classpath changes - #146
Merged
Merged
Conversation
prrvchr
force-pushed
the
build.xml.tpl
branch
from
February 13, 2025 02:33
06dbccd to
692c539
Compare
Contributor
Author
|
The dependency paths recorded in the |
Contributor
|
Thanks - but to keep things simple and comprehensible: Can you please do one fix per PR? You can have multiple local git branches for each problem, and submit a PR for each branch. |
Contributor
Author
|
Hi Samuel, ok I'll do it like this next time, sorry about that one... |
Contributor
|
Ok I extracted the fix for #145 and will merge the rest now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to improve the integration of Ant and
javacnow changes to the Eclipse.classpathfile will produce an update to thebuild.propertiesfile. This file has a new propertyuno.java.classpaththat allows to providejavacwith all the necessary dependencies when compiling.If in Eclipse a sibling project is declared as a dependency then either its jar archive (if it was produced by a
Build.jardescfile) or itsbinfolder (the folder where Eclipse puts the.classfiles) will be available in theuno.java.classpathproperty of thebuild.propertiesfile.This allows us to have compilations with
javac(ie: Ant) that work just as well as compilation by Eclipse's internal compiler.Concerning the Java jar archives to be put in the
MANIFEST.MFClass-Pathof a UNO Java project, there are two ways to do it:liborlibsfolder at the root of the UNO project. In this case all archives put in this folder are put in theClass-Pathof theMANIFEST.MF.liborlibsfolder, all archives local to the project and declared in the Eclipse build path will be put in theClass-Pathof theMANIFEST.MF.In addition to these changes who solves issue #144, I took the opportunity to correct issue #145.