Improved management of package.properties file - #123
Merged
Conversation
smehrbrodt
requested changes
Dec 23, 2024
| Bundle-Name: LibreOffice eclipse integration - core | ||
| Bundle-SymbolicName: org.libreoffice.ide.eclipse.core;singleton:=true | ||
| Bundle-Vendor: The Document Foundation | ||
| Bundle-Version: 4.0.2 |
Contributor
There was a problem hiding this comment.
Please no version bumps here. Will be done when released.
| mModel.write(); | ||
| mSourcePage.doRevertToSaved(); | ||
| writeToSource(mModel.write()); | ||
| //mSourcePage.doRevertToSaved(); |
Contributor
There was a problem hiding this comment.
Please remove unused code instead of commenting it out.
Contributor
Author
There was a problem hiding this comment.
I remove it but I don't know what this piece of code is for? On the other hand, if I leave it, we can no longer save correctly (the file still appears unsaved)
| Bundle-SymbolicName: org.libreoffice.ide.eclipse.python;singleton:=true | ||
| Bundle-Vendor: The Document Foundation | ||
| Bundle-Version: 4.0.2 | ||
| Bundle-Version: 4.0.3 |
| * | ||
| * GNU Lesser General Public License Version 2.1 | ||
| * ============================================= | ||
| * Copyright 2009 by Cédric Bosdonnat. |
Contributor
There was a problem hiding this comment.
copyright 2024 The Document Foundation
Comment on lines
+24
to
+27
| * The Initial Developer of the Original Code is: Cédric Bosdonnat. | ||
| * | ||
| * Copyright: 2009 by Cédric Bosdonnat. | ||
| * |
Contributor
There was a problem hiding this comment.
These lines can be removed.
| @@ -0,0 +1,212 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Contributor
There was a problem hiding this comment.
Is this file duplicated? Please delete the old file then.
Contributor
|
If you do more PRs, please keep them in smaller chunks (one logical change -> one PR) |
prrvchr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix issues #117 and issue #119.
in addition to these two corrections, many improvements have been made: