Conversation
Member
wesbiggs
commented
Oct 3, 2024
wesbiggs
commented
- open external links in a new tab (some via mdbook extension, others by hardcoding HTML)
- fix reference to deprecated public key announcement in PRId algorithm
- give a more useful internal link for assertionMethodPublicKeys in the Verifiable Credentials overview
- name items in the PRId description a little more consistently
- open external links in a new tab (some via mdbook extension, others by hardcoding HTML) - fix reference to deprecated public key announcement in PRId algorithm - give a more useful internal link for assertionMethodPublicKeys in the Verifiable Credentials overview
wesbiggs
force-pushed
the
fix/reference-to-pk-announcement
branch
from
44ad1a8 to
4a32145
Compare
shannonwells
approved these changes
Oct 4, 2024
Collaborator
shannonwells
left a comment
shannonwells
left a comment
There was a problem hiding this comment.
Changes look good. Reviewed code only, did not download the branch.
Member
Author
|
Ah, |
wesbiggs
force-pushed
the
fix/reference-to-pk-announcement
branch
from
38e30b9 to
21a54d7
Compare
wilwade
reviewed
Oct 14, 2024
| run: npm run lint | ||
|
|
||
| - name: Set up mdBook 📚 | ||
| uses: ./.github/workflows/common/set-up-mdbook |
Contributor
There was a problem hiding this comment.
If you are removing this, then you can also remove ./.github/workflows/common/set-up-mdbook
Member
Author
There was a problem hiding this comment.
I changed the common script instead. Running cargo install is slower, but more aligned with local usage, and this repo is not so time-sensitive.
added 2 commits
October 14, 2024 11:38
wilwade
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.