Conversation
pages/DSNP/UserData.md
Outdated
| "data": base64_string, | ||
| "etag": string, | ||
| "keyId": integer | ||
| "keyIndex": integer |
There was a problem hiding this comment.
Would this be a change to the https://github.com/LibertyDSNP/graph-sdk/ that needs to happen?
There was a problem hiding this comment.
I don't think this "example" JSON serialization is used directly in graph-sdk, but @aramikm or Joe might know better. I'll get some more eyes on it. If there's prior art out there using keyId I'd be fine with keeping it that way for simplicity's sake, but documenting that keyId is the index.
There was a problem hiding this comment.
Per Joe this won't impact graph-sdk, so resolving this thread.
There was a problem hiding this comment.
After thinking about this, I think this should just keep keyId. It is an identifier even if it applies an index algo.
wilwade
left a comment
wilwade
left a comment
There was a problem hiding this comment.
All looks correct to me!
wesbiggs
force-pushed
the
proposal/DIP-263_Use_User_Data_for_Public_Keys
branch
from
4391c5d to
5e03123
Compare
wilwade
left a comment
wilwade
left a comment
There was a problem hiding this comment.
Just updating my approval for the small additional updates.
2 participants
Problem
See #263
Solution