DIP-257 Attribute Sets and Attestation by wesbiggs · Pull Request #275 · LibertyDSNP/spec

wesbiggs · 2024-04-05T19:49:14Z

Problem

Link to GitHub Issue(s): #257

Solution

Adds affordances for Attribute Sets via the Verifiable Credentials format.
Adds three new announcement types for Attribute Sets.
Specifies DSNP compliance criteria for use of VCs, and includes DSNP extensions for chains of trust and display of credentials.
Extends DSNP Activity Content usage to enable Attestations as attachments.

pages/ActivityContent/Associated/Attachments.md

Other updates, fixes, and clarifications.

shannonwells

All my comments were addressed, looks good to go

jeanettedepatie

Generally we have some consistency issues with Announcement vs announcement, and YES/NO vs YES no. All links have been checked as well

jeanettedepatie · 2024-09-13T17:03:02Z

STYLEGUIDE.md

To the Style Guide I would add Activity Content - Uppercase A and C,
Verifiable Credentials - Uppercase V and C
Verifiable Credential Schema - Uppercase V, C and S
and
YES and no--When describing required items, use an all cap YES otherwise use a lowercase no.

jeanettedepatie · 2024-09-13T17:19:24Z

pages/ActivityContent/Associated/Attachments.md

+### Verifiable Credential Link
+
+Attestation attachments must contain a link to a Verifiable Credential document.
+The link must contain a relationship identifier in the form of a DSNP Attribute Set Type (the `rel` field), to allow applications to determine the type of credential expected.


remove comma after (the 'rel' field)

jeanettedepatie · 2024-09-13T17:22:25Z

pages/DSNP/Announcements.md

+| 10 | [External Content Attribute Set](Types/ExternalContentAttributeSet.md) | an attribute set for a non-DSNP content item | YES | YES |

 <sup>a</sup> Since DSNP version 1.2, social graph changes use [User Data](UserData.md) operations as described in the [Graph](Graph.md) section. 



Should we call out "b" as well as "a" down here?

It's there, just didn't show in the diff section.

jeanettedepatie · 2024-09-13T17:26:05Z

pages/DSNP/AttributeSets.md

+
+The conceptual model for Attribute Sets includes three types of data:
+
+1. A schema encoding rules for validating attribute set data. This MUST be in the form of a [DSNP Verifiable Credential Schema](../VerifiableCredentials/Types/VerifiableCredentialSchema.md) (a Verifiable Credential that contains a JSON Schema document).


is confusing to me. Do you mean A schema that encodes rules for validating attribute set data?

Yes. I'll use your wording.

jeanettedepatie · 2024-09-13T17:28:47Z

pages/DSNP/AttributeSets.md

+Attribute Set Type canonical names are constructed as follows:
+
+* MUST be in the format _attributeSetTypeNamespace_ + "`$`" + _attributeSetTypeName_, where _attributeSetTypeNamespace_ MUST be either a multihash content hash (encoded as a multibase string), the DSNP DID of the schema author (beginning with "`did:dsnp:`"), or the empty string (for schemaless attribute set types).
+* _attributeSetTypeName_ MUST match a declared type value in the Verifiable Credential document


Needs a period at the end of this sentence

jeanettedepatie · 2024-09-16T18:11:37Z

pages/VerifiableCredentials/Types/DID.md

+A DSNP DID document is a JSON-LD document representing key material associated with a DSNP User.
+
+| Property | Required | JSON Type | Description | Restrictions |
+| --- | --- | --- | --- | --- |


YES and NO should be YES and no to be consistent with other sections of the documentation.

jeanettedepatie · 2024-09-16T18:22:47Z

pages/VerifiableCredentials/Types/VerifiableCredentialSchema.md

+| --- | --- | --- | --- | --- |
+| `type` | YES | String | Type of subject matter | MUST be `JsonSchema` |
+| `jsonSchema` | YES | Object | Embedded JSON Schema object | See [JSON Schema](#json-schema) |
+| `dsnp` | NO | Object | DSNP extension object | See [DSNP Extensions](#dsnp-extensions) |


Again YES/NO is YES/no in other parts of the document. And this link does not work.

jeanettedepatie · 2024-09-16T18:29:23Z

pages/VerifiableCredentials/Types/VerifiableCredentialSchema.md

+| Property | Required | JSON Type | Description | Restrictions |
+| --- | --- | --- | --- | --- |
+| `type` | YES | Array of strings | Type of credential | MUST contain the strings `"VerifiableCredential"` and `"JsonSchemaCredential"` |
+|`credentialSubject` | YES | Object | Object containing JSON schema and DSNP extensions | See [Credential Subject](#credential-subject) |


This link does not work.

Working for me

I think these are only an issue when looking at the github renderings; the published docs are OK.

jeanettedepatie · 2024-09-16T18:30:05Z

pages/VerifiableCredentials/Types/VerifiableCredentialSchema.md

+| --- | --- | --- | --- | --- |
+| `type` | YES | Array of strings | Type of credential | MUST contain the strings `"VerifiableCredential"` and `"JsonSchemaCredential"` |
+|`credentialSubject` | YES | Object | Object containing JSON schema and DSNP extensions | See [Credential Subject](#credential-subject) |
+| `credentialSchema` | YES | Object | Metaschema defining JSON Schema types | See [Credential Schema](#credential-schema) |


This link does not work.

Working for me

jeanettedepatie · 2024-09-16T18:33:37Z

pages/VerifiableCredentials/Types/VerifiableCredentialSchema.md

+| Property | Required | JSON Type | Description | Restrictions |
+| --- | --- | --- | --- | --- |
+| `type` | YES | String | Type of subject matter | MUST be `JsonSchema` |
+| `jsonSchema` | YES | Object | Embedded JSON Schema object | See [JSON Schema](#json-schema) |


This link does not work.

Working for me

wesbiggs linked an issue Apr 5, 2024 that may be closed by this pull request

DIP-257 Attribute Set Announcements and attestation #257

Closed

wesbiggs force-pushed the proposal/attributes-attestation branch from 8309d04 to be8b188 Compare April 5, 2024 19:52

wesbiggs changed the title ~~Attribute Sets and Attestation~~ DIP-257 Attribute Sets and Attestation Apr 15, 2024

shannonwells reviewed Apr 26, 2024

View reviewed changes

pages/ActivityContent/Associated/Attachments.md Outdated Show resolved Hide resolved

pages/ActivityContent/Associated/Attachments.md Outdated Show resolved Hide resolved

pages/ActivityContent/Associated/Attachments.md Outdated Show resolved Hide resolved

wesbiggs force-pushed the proposal/attributes-attestation branch from 992df28 to a1a2182 Compare June 3, 2024 13:44

wesbiggs self-assigned this Jun 17, 2024

wesbiggs mentioned this pull request Jun 23, 2024

DIP-257 Attribute Set Announcements and attestation #257

Closed

wesbiggs and others added 2 commits August 13, 2024 12:41

DIP-257 Attribute Sets and attestation

c87310e

Minor doc fix

64dab1c

wesbiggs force-pushed the proposal/attributes-attestation branch from a1a2182 to 64dab1c Compare August 13, 2024 17:44

Wes Biggs added 3 commits August 29, 2024 10:23

Include support for VC 2.0 credentials.

5faa5c2

Other updates, fixes, and clarifications.

Lint fixes

3c9dc36

Link fix and more extensive DID example.

1691ec2

wesbiggs mentioned this pull request Aug 29, 2024

Add new announcement types for Attribute Sets LibertyDSNP/dsnp-schemas#1

Merged

wesbiggs requested review from shannonwells and wilwade August 29, 2024 14:56

shannonwells approved these changes Sep 11, 2024

View reviewed changes

wesbiggs requested a review from jeanettedepatie September 12, 2024 02:24

jeanettedepatie reviewed Sep 16, 2024

View reviewed changes

Review changes (mostly stylistic)

f23be50

wesbiggs requested a review from jeanettedepatie September 17, 2024 15:29

jeanettedepatie approved these changes Sep 17, 2024

View reviewed changes

wesbiggs merged commit 67c3786 into main Sep 17, 2024

wesbiggs deleted the proposal/attributes-attestation branch September 17, 2024 17:01

		\| 10 \| [External Content Attribute Set](Types/ExternalContentAttributeSet.md) \| an attribute set for a non-DSNP content item \| YES \| YES \|

		<sup>a</sup> Since DSNP version 1.2, social graph changes use [User Data](UserData.md) operations as described in the [Graph](Graph.md) section.


		The conceptual model for Attribute Sets includes three types of data:

		1. A schema encoding rules for validating attribute set data. This MUST be in the form of a [DSNP Verifiable Credential Schema](../VerifiableCredentials/Types/VerifiableCredentialSchema.md) (a Verifiable Credential that contains a JSON Schema document).

Conversation

wesbiggs commented Apr 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shannonwells left a comment

Choose a reason for hiding this comment

Uh oh!

jeanettedepatie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wesbiggs commented Apr 5, 2024 •

edited

Loading