Skip to content

Fixed Empty Button Icon Rendering#1

Merged
Levrk merged 1 commit intoBmpViewerfrom
menu-button-fix
Feb 14, 2026
Merged

Fixed Empty Button Icon Rendering#1
Levrk merged 1 commit intoBmpViewerfrom
menu-button-fix

Conversation

@Levrk
Copy link
Owner

@Levrk Levrk commented Feb 14, 2026

Summary

  • What is the goal of this PR? (e.g., Implements the new feature for file uploading.)

Empty Button Icons (I.E. Back button in the home menu) were still rendering the full sized white rectangles going passed the boarders of the little button nub. This was not visible on the home screen due to the white background, but it does cause issues if we ever want to have bmp files displayed while buttons are visible or implement a dark mode.

  • What changes are included?

Made it so that when a button hint text is empty string or null the displayed mini button nub does not have a white rectangle extending passed the bounds of the mini button nub

Additional Context

  • Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks,
    specific areas to focus on).

Having that extended rectangle was likely never noticed due to the only space where that feature is used being the main menu where the background is completely white. I am working on some new features that would have an image displayed while their are button hints and noticed this issue while implementing that.

One other note is that this only affects the Lyra Theme


AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? YES

Empty Button Icons (Back button in the home menu) were still rendering the full sized white rectangles. This was not visible on the home screen due to the white background.
@Levrk Levrk merged commit 63ecab7 into BmpViewer Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant