Repository navigation
Commit d3b7e8b
fix(desktop): resolve annotation tool shortcuts with fixed key cases
The preload shares the inspected page's JavaScript realm, so a plain object
lookup keyed by event.key also reads properties the page plants on
Object.prototype. A page setting Object.prototype.x = "send" turned a genuine
x key outside the overlay into a submission. Compare the four tool keys
directly again and pin the inherited-property case in the existing
outside-overlay test.
Co-Authored-By: Claude Fable 5.1 <[email protected]>1 parent ba21d8d commit d3b7e8b
2 files changed
Lines changed: 25 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
121 | 132 | | |
122 | 133 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | 24 | | |
32 | 25 | | |
33 | 26 | | |
| |||
55 | 48 | | |
56 | 49 | | |
57 | 50 | | |
58 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
59 | 65 | | |
60 | 66 | | |
61 | 67 | | |
| |||
0 commit comments