Skip to content

Commit ec4398d

Browse files
committed
Fixed pyspark indentation issue
see https://issues.apache.org/jira/browse/ZEPPELIN-34, should allow: %pyspark if True: print "one" else: print "two" def test_func(text): for i in range(1, 10): print text + '-' + str(i) test_func('fixed')
1 parent b33bf50 commit ec4398d

File tree

1 file changed

+7
-35
lines changed

1 file changed

+7
-35
lines changed

spark/src/main/resources/python/zeppelin_pyspark.py

Lines changed: 7 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,7 @@ def reset(self):
8585
try:
8686
stmts = req.statements().split("\n")
8787
jobGroup = req.jobGroup()
88-
single = None
89-
incomplete = None
90-
compiledCode = None
88+
final_code = None
9189

9290
for s in stmts:
9391
if s == None or len(s.strip()) == 0:
@@ -97,38 +95,13 @@ def reset(self):
9795
if s.strip().startswith("#"):
9896
continue
9997

100-
if s[0] != " " and s[0] != "\t":
101-
if incomplete != None:
102-
raise incomplete
103-
104-
if compiledCode != None:
105-
sc.setJobGroup(jobGroup, "Zeppelin")
106-
eval(compiledCode)
107-
compiledCode = None
108-
single = None
109-
incomplete = None
110-
111-
if single == None:
112-
single = s
98+
if final_code:
99+
final_code += "\n" + s
113100
else:
114-
single += "\n" + s
115-
116-
try :
117-
compiledCode = compile(single, "<string>", "single")
118-
incomplete = None
119-
except SyntaxError as e:
120-
if str(e).startswith("unexpected EOF while parsing") :
121-
# incomplete expression
122-
incomplete = e
123-
continue
124-
else :
125-
# actual error
126-
raise e
127-
128-
if incomplete != None:
129-
raise incomplete
130-
131-
if compiledCode != None:
101+
final_code = s
102+
103+
if final_code:
104+
compiledCode = compile(final_code, "<string>", "exec")
132105
sc.setJobGroup(jobGroup, "Zeppelin")
133106
eval(compiledCode)
134107

@@ -137,4 +110,3 @@ def reset(self):
137110
intp.setStatementsFinished(str(sys.exc_info()), True)
138111

139112
output.reset()
140-

0 commit comments

Comments
 (0)