fix(grep): handle file paths without ENOTDIR error#233
Merged
LeeCheneler merged 1 commit intomainfrom Mar 29, 2026
Merged
Conversation
When the path argument points to a file instead of a directory, use the file's parent as cwd and grep the specific file. Previously this caused an ENOTDIR error from execSync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix ENOTDIR error when the grep tool receives a file path instead of a directory path.
What Changed
When
pathpoints to a file, the grep tool now uses the file's parent directory ascwdand greps the specific file directly. Previously it passed the file path as the working directory toexecSync, causingspawnSync /bin/sh ENOTDIR.Two tests added: searching a single file by path, and no-matches for a single file.