-
Notifications
You must be signed in to change notification settings - Fork 3
DynamicVersion fails with FALLBACK_VERSION + git #32
Copy link
Copy link
Closed
Description
CMakeExtraUtils/cmake/DynamicVersion.cmake
Lines 511 to 527 in eac47a4
| execute_process(COMMAND ${GIT_EXECUTABLE} status | |
| WORKING_DIRECTORY ${ARGS_PROJECT_SOURCE} | |
| RESULT_VARIABLE git_status_result | |
| OUTPUT_QUIET) | |
| if (NOT git_status_result EQUAL 0) | |
| message(${error_message_type} | |
| "Project source is neither a git repository nor a git archive:\n" | |
| " Source: ${ARGS_PROJECT_SOURCE}" | |
| ) | |
| return() | |
| endif () | |
| # Get version and describe-name | |
| execute_process(COMMAND ${GIT_EXECUTABLE} describe --tags --long --match=?[0-9.]* | |
| WORKING_DIRECTORY ${ARGS_PROJECT_SOURCE} | |
| OUTPUT_VARIABLE describe-name | |
| OUTPUT_STRIP_TRAILING_WHITESPACE | |
| COMMAND_ERROR_IS_FATAL ANY) |
Should remove COMMAND_ERROR_IS_FATAL ANY and instead parse the exit code
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels