Repository navigation
fix: enforce parent-first langchain splitter imports - #6226
LearningCircuit merged 8 commits into
Conversation
|
Welcome to local-deep-research — and thank you for your contribution. We genuinely appreciate the time you're putting in. Here's a starter pack to help your PR move smoothly: Get set up locally
Understand the codebase
Before you ask for review
A maintainer will take a look — if you don't hear back within 7 days, feel free to ping. |
|
This is the right shape for #6143, and the enforcement half is better than what the issue asked for. Verified on this head:
One note, not a blocker: the guard requires the parent import in the same executable scope, so a module-level parent import will not satisfy a function-level submodule import. That is stricter than the runtime requirement (once the parent is in Decision: APPROVED AI-assisted review. |
|
@AbarnaaSree if i squash merge this it will expose your gmail email address are you fine with this? In github there is a setting to always use noreply email addresses you could also do that. |
|
@AbarnaaSree converting this temporarily to draft so nothing can happen - awaiting your response than we can merge it. |
|
Thanks for checking! I’d prefer to keep my Gmail address private. I’ll use my GitHub noreply email instead. |
Summary
_LANGCHAIN_TEXT_SPLITTERS_IMPORT_LOCK.langchain_text_splittersimports function-local and lazy.langchain_text_splitterssubmodule imports.#4829release-note narrative.Testing
34 passedgit diff --checkpassedFixes #6143