Fix type error when adding padded bytes.#90
Merged
Lazza merged 2 commits intoLazza:masterfrom Jul 13, 2021
Merged
Conversation
.gitignore
Outdated
| *.code-workspace | ||
|
|
||
| # PyCharm | ||
| .idea/ |
Contributor
There was a problem hiding this comment.
ideally this kind of line should be done on your general .gitignore, not the project's gitignore (but honestly it's not a big deal). Because the project itself doesn't generate any .idea folder, and we don't want to clutter the .gitignore with all the editor specific things that might be needed.
Contributor
Author
There was a problem hiding this comment.
I added it since I saw that there are vscode exclusions just above. I removed the change to the .gitignore file and added to my local exclusions file instead.
Owner
|
Sorry that I left this opened a bit too much. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During recovery of one of the partitions, I got the following error:
This PR just prefixes the string with
bto convert it to a bytes instance instead of str, so that the function doesn't require an encoding.