Skip to content

Comments

Update fuji.py#13

Merged
Lazza merged 1 commit intoLazza:tmp-devices-listfrom
BrunoFischerGermany:add---new-window-listed-disks
Aug 18, 2024
Merged

Update fuji.py#13
Lazza merged 1 commit intoLazza:tmp-devices-listfrom
BrunoFischerGermany:add---new-window-listed-disks

Conversation

@BrunoFischerGermany
Copy link
Contributor

- Add new Window to show all Disks an Devices, if double-click to an mounted device, it is the source then
@BrunoFischerGermany
Copy link
Contributor Author

image
image
@Lazza

@Lazza
Copy link
Owner

Lazza commented Aug 18, 2024

I am going to merge this on a separate branch, in order to see if I need to modify something before merging.

@Lazza Lazza changed the base branch from master to tmp-devices-list August 18, 2024 18:00
@Lazza Lazza merged commit a903700 into Lazza:tmp-devices-list Aug 18, 2024
@Lazza
Copy link
Owner

Lazza commented Aug 18, 2024

Thank you for proposing this patch. I checked the code after merging it in a test branch, unfortunately it is not currently ready to be used.

The following points need to be addressed first:

  • After clicking the button, the program stalled for about 8 seconds before the table was shown
  • At one click, 49 instance of subprocess.Popen were invoked (probably the main cause for the large delay)
  • Many calls are repeated and then filtered in a different way
  • Some comments are in German
  • Some parsing code seems pretty fragile, with magic numbers that may change on some systems (e.g. deviceline[5:33].split() or stringUsedSpaceFullString[38:46].split()
  • The font of the descriptive line at the top is Lucida Grande rather than the standard San Francisco font

I like the idea of this table and I think it might be a useful addition, but first I need to see if it can be reworked to address the mentioned points.

@BrunoFischerGermany
Copy link
Contributor Author

Hello @Lazza

Thank you very much for your feedback.

I also think that the table could be useful.
I had to do the lines with the magic numbers because the return of the command line is formatted that way.

I would look at my code again and suggest something different if necessary.

Thanks and best regards
Bruno

@Lazza
Copy link
Owner

Lazza commented Aug 21, 2024

I have rewritten most of the parsing code and the UI in the branch: Lazza:tmp-devices-list

The GUI is now striped and it does not show a "size" for APFS Volumes (they have an intrinsic size based on the occupied space so they would seem always "100%" full). The size for "/" is completely wrong because it picks it from the first system partition, thus I have added a special case that estimates the size.

Unmounted entries cannot be clicked nor highlighted.

The dark mode has been tested as well. The following step is merging this into the main branch.

Screenshot 2024-08-21 alle 23 21 21 Screenshot 2024-08-21 alle 23 21 00

@Lazza Lazza mentioned this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants