Improved Pipe resolving #275
Conversation
|
One thing. You should also add the ability to add/remove custom pipe paths for future proofing the library in case there may be name changes which won't likely happen but is possible. |
This would cause each dependant to keep track of the pipe names themselves and handle it manually. I feel like this library should be able to handle this. A contribution guide on how to add/fix pipe paths would be useful. In the end of the day, this is a "linux issue". Due to the nature of enthusiasts, there will always be a million different ways to implement a pipe and that burden shouldn't be on game developers. This library should be a plugin play. |
Refactored how the pipe is resolved for all operating systems. This is done to be able to support more package managers on Linux such as the issue #270 .
This does require the removal of several APIs within the ManagedNamedPipe, which is a breaking change. These have been marked as obsolete but as their implementation was removed it has been marked as erroring.
Features
Migration
DiscordRPC.IO.PipeLocation.GetPipes:DiscordRPC.IO.ManagedNamedPipeClient.GetPipeName(int)DiscordRPC.IO.ManagedNamedPipeClient.GetPipeName(int, string)DiscordRPC.IO.ManagedNamedPipeClient.GetPipeSandbox()DiscordRPC.IO.ManagedNamedPipeClient.IsUnix()DiscordRPC.IO.INamedPipeClient.ConnectedPipeDiscordRPC.Message.ConnectionEstablishedMessage.ConnectedPipe