Merge updates from public repo #1
Merged
Sigmonia merged 22 commits intoLabKey:fb_config_mfafrom Feb 22, 2019
Merged
Conversation
* Fix typo in rpm install output text * Fix file name
bump version
Add argument to install script to specify release
curiositycasualty
approved these changes
Feb 22, 2019
Sigmonia
approved these changes
Feb 22, 2019
Sigmonia
left a comment
Sigmonia
left a comment
There was a problem hiding this comment.
Looks fine. a lot of clean up of escapes and logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created a pull request to pull in the latest changes from the public repo and merge to my fb_config_mfa branch.
These changes appear to be fairly harmless and result in improvements. We already use our own install script via chef cookbook so changes to the install script are not used.
Our Chef cookbook uses the following scripts from the source repo:
authorized_keys_command.sh
import_users.sh
install_configure_selinux.sh
install_configure_sshd.sh
install_restart_sshd.sh