Skip to content

Type conversion (maybe corrupting data)? #409

@sn248

Description

@sn248

Hi

I am trying to update my R package sundialr which is an interface to some of the solvers in SUNDIALS. The CRAN checks for my package give -Woverflow warnings. I discussed this issue in r-package-devel forum where another user thought I should bring it to the attention of the library since it may be corrupting data.

See the entire issue here -

https://stat.ethz.ch/pipermail/r-package-devel/2024q1/010431.html

I am not able to submit to CRAN due to this error.

Specifically, these are the warnings I am getting

Flavor: r-devel-windows-x86_64
Check: whether package can be installed, Result: WARNING
Found the following significant warnings:
./sundials/sundials/sundials_hashmap.h:26:48: warning: conversion from
'long long unsigned int' to 'long unsigned int' changes value from
'14695981039346656037' to '2216829733' [-Woverflow]
./sundials/sundials/sundials_hashmap.h:27:48: warning: conversion from
'long long unsigned int' to 'long unsigned int' changes value from
'1099511628211' to '435' [-Woverflow]
sundials/sundials/sundials_hashmap.h:26:48: warning: conversion from
'long long unsigned int' to 'long unsigned int' changes value from
'14695981039346656037' to '2216829733' [-Woverflow]
sundials/sundials/sundials_hashmap.h:27:48: warning: conversion from
'long long unsigned int' to 'long unsigned int' changes value from
'1099511628211' to '435' [-Woverflow]
sundials/sundials/sundials_profiler.c:71:24: warning: function
declaration isn't a prototype [-Wstrict-prototypes]
See 'd:/RCompile/CRANincoming/R-devel/sundialr.Rcheck/00install.out' for
details.
Used C++ compiler: 'g++.exe (GCC) 12.3.0'

and

Flavor: r-devel-linux-x86_64-debian-gcc
Check: whether package can be installed, Result: WARNING
Found the following significant warnings:
sundials/sundials/sundials_profiler.c:71:41: warning: a function
declaration without a prototype is deprecated in all versions of C
[-Wstrict-prototypes]
See '/srv/hornik/tmp/CRAN/sundialr.Rcheck/00install.out' for details.
Used C++ compiler: 'Debian clang version 17.0.6 (5)'

Any update on this would be highly appreciated!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions