Fix loading of adequate knowledge base entries on section 3.1 (measures)#848
Merged
Conversation
…the slug (PIA_CUSTOM_31)
…es on the measures section
…on its category (#849)
kevin-atnos
merged commit 71bd009
into
CU-86c3p2fmu_Probleme-daffichage-des-bases-de-connaissance-existantes-dans-la-liste-des-bases-de-connaissance
1 check passed
kevin-atnos
deleted the
CU-86c3p23rn_ClientServeur-Probleme-de-chargement-des-bons-elements-dune-base-de-connaissance-personnalisee-dans-la-section-des-mesures-31
branch
kevin-atnos
added a commit
that referenced
this pull request
Jan 26, 2026
…reshing the page (#847) * feat: properly loads knowledge bases (default and custom ones) * Fix loading of adequate knowledge base entries on section 3.1 (measures) (#848) * feat: filter knowledge base items on section 3.1 (measures) based on the slug (PIA_CUSTOM_31) * fix: knowledge base item sorting for custom and default knowledge bases on the measures section * feat: register correctly the 31 item to a knowledge base entry based on its category (#849)
kevin-atnos
added a commit
that referenced
this pull request
Jan 26, 2026
…ame on language change (+ ISO code update) (#846) * feat: fix translations update on risks overview graph + fix CZ (CS) and DK (DA) languages ISO codes * feat: update default knowledge base name on language change * Fix the loading of knowledge bases (default and custom ones) when refreshing the page (#847) * feat: properly loads knowledge bases (default and custom ones) * Fix loading of adequate knowledge base entries on section 3.1 (measures) (#848) * feat: filter knowledge base items on section 3.1 (measures) based on the slug (PIA_CUSTOM_31) * fix: knowledge base item sorting for custom and default knowledge bases on the measures section * feat: register correctly the 31 item to a knowledge base entry based on its category (#849)
kevin-atnos
added a commit
that referenced
this pull request
Jan 26, 2026
…n the Measures page (#843) * fix: loading and behavior of the Add measure button in Structures * Fix translations on risks overview graph and default knowledge base name on language change (+ ISO code update) (#846) * feat: fix translations update on risks overview graph + fix CZ (CS) and DK (DA) languages ISO codes * feat: update default knowledge base name on language change * Fix the loading of knowledge bases (default and custom ones) when refreshing the page (#847) * feat: properly loads knowledge bases (default and custom ones) * Fix loading of adequate knowledge base entries on section 3.1 (measures) (#848) * feat: filter knowledge base items on section 3.1 (measures) based on the slug (PIA_CUSTOM_31) * fix: knowledge base item sorting for custom and default knowledge bases on the measures section * feat: register correctly the 31 item to a knowledge base entry based on its category (#849)
kevin-atnos
added a commit
that referenced
this pull request
Jan 26, 2026
…n the Measures page (#843) * fix: loading and behavior of the Add measure button in Structures * Fix translations on risks overview graph and default knowledge base name on language change (+ ISO code update) (#846) * feat: fix translations update on risks overview graph + fix CZ (CS) and DK (DA) languages ISO codes * feat: update default knowledge base name on language change * Fix the loading of knowledge bases (default and custom ones) when refreshing the page (#847) * feat: properly loads knowledge bases (default and custom ones) * Fix loading of adequate knowledge base entries on section 3.1 (measures) (#848) * feat: filter knowledge base items on section 3.1 (measures) based on the slug (PIA_CUSTOM_31) * fix: knowledge base item sorting for custom and default knowledge bases on the measures section * feat: register correctly the 31 item to a knowledge base entry based on its category (#849)
kevin-atnos
added a commit
that referenced
this pull request
Jan 26, 2026
* fix: no longer adds 2 identical measures in the structures when adding one with the Plus button * fix: Loading and behavior of the "Add measure" button in Structures on the Measures page (#843) * fix: loading and behavior of the Add measure button in Structures * Fix translations on risks overview graph and default knowledge base name on language change (+ ISO code update) (#846) * feat: fix translations update on risks overview graph + fix CZ (CS) and DK (DA) languages ISO codes * feat: update default knowledge base name on language change * Fix the loading of knowledge bases (default and custom ones) when refreshing the page (#847) * feat: properly loads knowledge bases (default and custom ones) * Fix loading of adequate knowledge base entries on section 3.1 (measures) (#848) * feat: filter knowledge base items on section 3.1 (measures) based on the slug (PIA_CUSTOM_31) * fix: knowledge base item sorting for custom and default knowledge bases on the measures section * feat: register correctly the 31 item to a knowledge base entry based on its category (#849)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filtering on measure. was wrong because sometimes entries had the filter measure. enabled but were not enabled for the section 3.1 in the Knowledge Base module, so they were visible even if not supposed to be. To use the slug is more accurate because if the slug is 31, it means the entry was added to section 3.1.