fix: adjust gauge input enable/disable logic#819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how the "gauge" input is enabled or disabled in the
QuestionsComponent. The logic for disabling the input is moved from the template to the TypeScript code, improving maintainability and clarity.Form control state management:
gaugeinput is now handled programmatically in the component's TypeScript file using theisInputDisabled()method, instead of using a complex conditional in the template. (src/app/modules/pia/content/questions/questions.component.ts)[attr.disabled]binding with a multi-condition expression has been removed from the template, simplifying the HTML and delegating control state to the component logic. (src/app/modules/pia/content/questions/questions.component.html)