feat: upgrade TinyMCE to v8.0.2 and update configurations for enhanced editor functionality#818
Merged
kevin-atnos merged 10 commits intomasterfrom Oct 8, 2025
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades TinyMCE from version 4.9.11 to 8.0.2, requiring significant configuration and integration updates throughout the Angular application. The upgrade modernizes the editor functionality and improves maintainability by aligning with the latest TinyMCE features and API changes.
- Upgraded TinyMCE dependency to version 8.0.2 and updated build configuration
- Updated TinyMCE initialization configuration across all editor components
- Refactored editor cleanup logic and replaced deprecated styling selectors
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates TinyMCE dependency from 4.9.11 to 8.0.2 |
| angular.json | Modifies asset copying and script loading for TinyMCE 8 compatibility |
| src/assets/stylesheets/_editor.scss | Replaces legacy TinyMCE 4 CSS selectors with TinyMCE 8 equivalents |
| Multiple component files | Updates TinyMCE initialization with new configuration options and cleanup methods |
Comments suppressed due to low confidence (1)
src/app/modules/structure/content/questions/questions.component.ts:1
- The editor cleanup may cause race conditions when called during the
focusoutevent handler. Consider adding a check to ensure the editor is still valid before callingtinymce.remove(this.editor).
import {
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
66ef04f to
f744414
Compare
Collaborator
|
f744414 to
a5092d1
Compare
…d editor functionality # Conflicts: # yarn.lock
cf09ed0 to
716c2f3
Compare
kevin-atnos
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request upgrades TinyMCE from version 4 to version 8 and updates its integration throughout the Angular application. The changes include updating how TinyMCE is loaded and initialized, modifying editor configuration options, and refactoring related styles to support the new version. These updates ensure compatibility with the latest TinyMCE features and improve maintainability.
TinyMCE Upgrade and Integration
package.jsonand updated asset handling inangular.jsonto copy the new TinyMCE files and usetinymce.min.jsinstead of older scripts/styles. [1] [2] [3]evaluations.component.ts,measures.component.ts,questions.component.ts) to use new configuration options (license_key,base_url,suffix, andplaceholder) and removed deprecatedskinoption. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Editor Lifecycle and Cleanup
questions.component.tsby introducing a new privatecloseEditor()method to handle editor removal and placeholder reset, improving code clarity and reliability. [1] [2]Styling Updates for TinyMCE 8
_editor.scsswith new selectors and styles compatible with TinyMCE 8, including updates for.tox-tinymceelements and toolbar appearance.