Skip to content

Feature/add some update for ux UI#709

Merged
kevin-atnos merged 7 commits intomasterfrom
feature/add-some-update-for-ux-ui
Apr 25, 2023
Merged

Feature/add some update for ux UI#709
kevin-atnos merged 7 commits intomasterfrom
feature/add-some-update-for-ux-ui

Conversation

@syl-p
Copy link
Copy Markdown
Contributor

@syl-p syl-p commented Mar 31, 2023

No description provided.

localStorage.setItem('client_id', this.settingsForm.value.client_id);
localStorage.setItem(
'client_secret',
this.settingsForm.value.client_secret

Check failure

Code scanning / CodeQL

Clear text storage of sensitive information

This stores sensitive data returned by [an access to client_secret](1) as clear text.
@syl-p syl-p marked this pull request as ready for review March 31, 2023 14:42
@syl-p syl-p requested review from brunto and kevin-atnos March 31, 2023 14:49
@kevin-atnos kevin-atnos merged commit 02e88ef into master Apr 25, 2023
@kevin-atnos kevin-atnos deleted the feature/add-some-update-for-ux-ui branch December 11, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants