Repository navigation
test(base-contract-io): pass real ethers exports through module mock - #971
Merged
Merged
Conversation
Node 24.21.0 (nodejs/node#62943) makes mock.module() also intercept require() of dual CJS/ESM packages. The skipped mock-contract suite replaced ethers with only { Wallet, Contract }, so loading resyncing-nonce-manager.js threw 'Class extends value undefined' when extending ethers.NonceManager, failing main's nightly CI since the runners picked up 24.21. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Andres Olave <[email protected]>
Contributor
|
||||||||||||||
Contributor
Coverage ReportCoverage Summary (PR)Worst 4 packages by coverage
Worst 2 files by uncovered lines
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test (@verii/base-contract-io)withTypeError: Class extends value undefined is not a constructor or null.mock.module()also interceptrequire()of dual CJS/ESM packages. CI usesnode-version: 24.x, so it picked this up automatically.test/mock-contract.test.js(its suite isdescribe.skip) mocksetherswith only{ Wallet, Contract }. On 24.21 that mock reachessrc/resyncing-nonce-manager.js, soextends ethers.NonceManagerthrows when the file loads.ethersexports into the mock, asblockchain-functions/test/eth.test.jsalready does. Test-only change.Test plan
🤖 Generated with Claude Code