Skip to content

Wrap high-pass filtered RIR in np.ascontiguousarray#423

Merged
fakufaku merged 3 commits into
LCAV:masterfrom
mattpitkin:rir_contiguous_array
Jan 23, 2026
Merged

Wrap high-pass filtered RIR in np.ascontiguousarray#423
fakufaku merged 3 commits into
LCAV:masterfrom
mattpitkin:rir_contiguous_array

Conversation

@mattpitkin
Copy link
Copy Markdown
Contributor

This PR fixes #421 by wrapping the output of the sosfiltfilt function in compute_rir in the np.ascontiguousarray function.

  • Are there docstrings ? Do they follow the numpydoc style ?
  • Have you run the tests by doing nosetests or py.test at the root of the repo ?
  • Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
  • Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

@mattpitkin
Copy link
Copy Markdown
Contributor Author

I've also added a fix to an issue that cause the CI to fail with NumPy v2.4. The deprecation warning introduced in numpy/numpy#10615 expired and was removed in NumPy v2.4 numpy/numpy#29841.

@fakufaku
Copy link
Copy Markdown
Collaborator

LGTM. Thanks!

@fakufaku fakufaku merged commit 285cadb into LCAV:master Jan 23, 2026
24 checks passed
@mattpitkin mattpitkin deleted the rir_contiguous_array branch January 23, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default highpass filtering of RIR results in non-contiguous arrays

2 participants