Repository navigation
Commit e06d70d
authored
[web] Capture pointers to the Flutter view so drags survive platform view iframes (flutter#195187)
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->
On Flutter Web, a drag that starts on Flutter content stops receiving
`pointermove` events when the pointer moves over an `<iframe>` platform
view, because the browser routes those events to the iframe document
instead of the host window. As a result, the dragged widget freezes over
the iframe and jumps when the pointer re-enters Flutter content.
This PR captures the pointer to the `<flutter-view>` root on
`pointerdown` when the press targets Flutter content (`_viewTarget` or
`flt-glass-pane`, to which events inside the scene's shadow root are
retargeted), and cancels still-pressed pointers if capture on the view
root is involuntarily lost (`lostpointercapture`). Presses on platform
views, the text-editing host, and the semantics host are excluded so
native HTML interactions, text selection, and `ClickDebouncer`
accessibility clicks continue to work on their original targets.
This change ships separately from automatic pointer interceptors so that
pointer-routing changes for all Flutter web apps can be reviewed and
reverted independently.
**Review hot spots**
- **Boundary events during a captured drag:**
`pointerover`/`out`/`enter`/`leave` on other elements (including
`pointerleave` on the view root when dragging outside the window) are
suppressed until release.
- **Involuntary capture loss (`lostpointercapture`):** cancels active
presses if capture on `_viewTarget` is lost before
`pointerup`/`pointercancel` (e.g. window blur or
`releasePointerCapture`), while ignoring `lostpointercapture` after
normal release or bubbling from platform view descendants.
- **Clicks and semantics:** after a captured press, `click` lands on the
view root. `semanticsHost` is excluded from capture so `ClickDebouncer`
and assistive-technology `flt-tappable` activation remain unchanged
(drags starting on semantics nodes remain uncaptured over iframes).
- **Touch, pen, and multi-view:** touch already has implicit capture
(moving it to the view root is benign), pen drags gain capture alongside
mouse drags, and each view captures to its own root.
Fixes flutter#141307
Related: flutter#157968,
flutter#134652
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.
**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md1 parent b1e1fa6 commit e06d70d
2 files changed
Lines changed: 409 additions & 10 deletions
File tree
- engine/src/flutter/lib/web_ui
- lib/src/engine
- test/engine
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
931 | 931 | | |
932 | 932 | | |
933 | 933 | | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
934 | 937 | | |
935 | 938 | | |
936 | 939 | | |
| |||
1095 | 1098 | | |
1096 | 1099 | | |
1097 | 1100 | | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
| 1118 | + | |
| 1119 | + | |
| 1120 | + | |
| 1121 | + | |
| 1122 | + | |
| 1123 | + | |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
| 1128 | + | |
| 1129 | + | |
| 1130 | + | |
| 1131 | + | |
| 1132 | + | |
| 1133 | + | |
| 1134 | + | |
| 1135 | + | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
1098 | 1150 | | |
1099 | 1151 | | |
1100 | 1152 | | |
| |||
1116 | 1168 | | |
1117 | 1169 | | |
1118 | 1170 | | |
| 1171 | + | |
1119 | 1172 | | |
1120 | 1173 | | |
1121 | 1174 | | |
| |||
1134 | 1187 | | |
1135 | 1188 | | |
1136 | 1189 | | |
1137 | | - | |
1138 | | - | |
1139 | | - | |
1140 | | - | |
1141 | | - | |
1142 | | - | |
1143 | | - | |
1144 | | - | |
1145 | | - | |
1146 | | - | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
| 1194 | + | |
| 1195 | + | |
1147 | 1196 | | |
1148 | 1197 | | |
1149 | 1198 | | |
| |||
1220 | 1269 | | |
1221 | 1270 | | |
1222 | 1271 | | |
| 1272 | + | |
| 1273 | + | |
| 1274 | + | |
| 1275 | + | |
| 1276 | + | |
| 1277 | + | |
| 1278 | + | |
| 1279 | + | |
| 1280 | + | |
| 1281 | + | |
| 1282 | + | |
| 1283 | + | |
| 1284 | + | |
| 1285 | + | |
| 1286 | + | |
| 1287 | + | |
| 1288 | + | |
| 1289 | + | |
| 1290 | + | |
| 1291 | + | |
| 1292 | + | |
| 1293 | + | |
| 1294 | + | |
| 1295 | + | |
| 1296 | + | |
| 1297 | + | |
| 1298 | + | |
| 1299 | + | |
| 1300 | + | |
1223 | 1301 | | |
1224 | 1302 | | |
1225 | 1303 | | |
| |||
0 commit comments