Repository navigation
Fix ReplaceWith on deprecated Instant.toEpochMilliseconds and isDistantFuture - #650
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
ReplaceWithexpressions on the deprecatedkotlinx.datetime.Instantname a different member than the one they annotate.toEpochMilliseconds()offersthis.toStdlibInstant().nanosecondsOfSecondas its replacement, in theexpectdeclaration and bothactualones, andisDistantFutureoffersthis.toStdlibInstant().isDistantPast. An IDE quick-fix applied to either changes the program's result and leaves no warning behind.This corrects the four expressions to the same-named member on
kotlin.time.Instant. Annotation-only, so no test.Found by an automated audit; the change was reviewed and verified by a person on a fresh clone with jvmTest, jsTest and wasmJsTest.