You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 13, 2026. It is now read-only.
Repository navigation
Commit aff3f01
Browse filesBrowse the repository at this point in the historyBrowse files
fix: release-audit batch — node:sqlite CI coverage, embedding-runtime doctor parity
Cleared the source-verified findings from the two blind release councils
(0 P0 either; these are the P1/P2 hardening items).
cortexkit#2 — bind-style CI guard scope: sqlite-bind-style.test.ts scanned only
plugin/src, so an array-form bind (cortexkit#151 class: works on bun:sqlite, throws
"Unknown named parameter '0'" on node:sqlite) written in pi-plugin/src or cli/src
would ship undetected. Now scans all three package srcs (zero existing
violations). pi-plugin and cli have no sqlite.ts of their own — they run on the
shared chokepoint — so a bind there is just as dangerous.
cortexkit#3 — node:sqlite smoke in CI: bun test only exercises the bun:sqlite branch, so
the transaction() shim, readonly→readOnly mapping, and the cortexkit#151 array-bind
normalization shipped unverified under real node:sqlite (Pi / Desktop). Wired
scripts/smoke-node-sqlite.ts into ci.yml (check-plugin) and release.yml (test)
behind a Node 24 setup; it exits non-zero on failure so it gates.
cortexkit#4 — Pi doctor embedding-runtime parity (cortexkit#128): doctor-opencode detects a broken
local onnxruntime-node, doctor-pi didn't. Added a LAYOUT-AGNOSTIC
checkLocalEmbeddingRuntimeByResolution that asks Node's resolver from the
installed plugin dir (direct, then through @huggingface/transformers for pnpm
strict) instead of guessing a path — verified empirically that Pi's real layout
varies (local dev-path bun workspace vs npm-hoisted user/project install). Stays
"unknown"/silent when it can't introspect, never false-alarms. Caught a
Bun-vs-Node divergence under test: Bun's resolver throws a ResolveMessage that is
NOT instanceof Error, so reading .code defensively (not gated on instanceof) is
required — the doctor runs under Node (npx) but tests under Bun, so both paths
are now covered.
cortexkit#6 — OpenCode doctor no-config path: local is the DEFAULT provider, so a missing
config still means local embeddings; it now runs the runtime check there too via
a shared checkLocalEmbeddingRuntimeForDoctor helper (was an early return).
cortexkit#7 — ERR_DLOPEN_FAILED latch: onnxruntime-node installed but its native binary
fails to load (Windows missing VC++ runtime) is environmental+permanent, same
class as missing-package — isNativeRuntimeMissingError now latches it (scoped to
onnxruntime so unrelated native-module failures aren't masked).
cortexkit#1 (subagent Channel-2) reviewed and intentionally left as-is: the one-shot lease
is consumed at a mid-work tool-calls boundary (promptAsync coalesces into the
live loop); worst case is a ~100-token revival in the tiny pre-stop window.
Gate: plugin 2086/0, Pi 469/0, CLI 165/0; tsc + biome clean all three.
Empirically dry-run the live Pi doctor (openai-compatible config → local branch
correctly silent; resolution chain proven to find the binary on disk).
Co-authored-by: Alfonso [Magic Context] <[email protected]>
0 commit comments